Shekharrajak commented on code in PR #19510:
URL: https://github.com/apache/druid/pull/19510#discussion_r3295038545


##########
extensions-contrib/druid-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/IcebergInputSource.java:
##########
@@ -134,6 +177,9 @@ public Stream<InputSplit<List<String>>> createSplits(
   @Override
   public int estimateNumSplits(InputFormat inputFormat, @Nullable 
SplitHintSpec splitHintSpec) throws IOException
   {
+    if (useArrowReader) {
+      return 1;

Review Comment:
   Future PR: Enable parallel ingestion (maxNumConcurrentSubTasks > 1) when 
useArrowReader: true by adding split-coordination plumbing to 
IcebergInputSource. Currently Arrow mode forces a single subtask to guarantee 
correctness;



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to