FrankChen021 commented on code in PR #19510:
URL: https://github.com/apache/druid/pull/19510#discussion_r3298115181
##########
extensions-contrib/druid-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/IcebergInputSource.java:
##########
@@ -113,6 +125,16 @@ public InputSourceReader reader(
File temporaryDirectory
)
{
+ if (useArrowReader) {
Review Comment:
Thanks, this now enforces `FAIL` for Arrow before constructing the reader.
One remaining parity gap: the enforcement scan does not apply `snapshotTime`,
but `IcebergArrowInputSourceReader.buildScan()` later reads
`asOfTime(snapshotTime)`. With `useArrowReader=true`,
`residualFilterMode=FAIL`, and a historical snapshot, this can fail or pass
based on the current snapshot instead of the snapshot being ingested. Can you
apply `snapshotTime` to the `TableScan` before `enforceResidualMode`, or share
the same scan-building path with the reader?
Reviewed 7 of 7 changed files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
