clintropolis commented on code in PR #19460:
URL: https://github.com/apache/druid/pull/19460#discussion_r3352552408
##########
processing/src/main/java/org/apache/druid/segment/IndexIO.java:
##########
@@ -983,31 +1009,51 @@ public QueryableIndex load(File inDir, ObjectMapper
mapper, boolean lazy, Segmen
);
projectionsColumns.put(projectionSpec.getSchema().getName(),
projectionColumns);
- if (projectionSpec.getSchema() instanceof AggregateProjectionSchema) {
- aggProjections.add(
- new AggregateProjectionMetadata(
- (AggregateProjectionSchema) projectionSpec.getSchema(),
- projectionSpec.getNumRows()
- )
- );
- } else {
- throw DruidException.defensive(
- "Unexpected projection[%s] with type[%s]",
- projectionSpec.getSchema().getName(),
- projectionSpec.getSchema().getClass()
- );
+ aggProjections.add(
+ new AggregateProjectionMetadata(
+ (AggregateProjectionSchema) projectionSpec.getSchema(),
+ projectionSpec.getNumRows()
+ )
+ );
+ }
+
+ final List<Map<String, Supplier<BaseColumnHolder>>>
clusterGroupColumnsList;
+ if (isClusteredSummary) {
Review Comment:
there are a handful of places we use this, so its a bit clearer to convert
to boolean so i left this as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
