clintropolis commented on code in PR #19460:
URL: https://github.com/apache/druid/pull/19460#discussion_r3352579874
##########
processing/src/main/java/org/apache/druid/segment/IndexIO.java:
##########
@@ -952,16 +954,33 @@ public QueryableIndex load(File inDir, ObjectMapper
mapper, boolean lazy, Segmen
// projections can omit a __time column, but one still has to exist, so
we use the interval start to make a
// constant for this case
final long intervalStartMillis =
Intervals.of(metadata.getInterval()).getStartMillis();
- // read base table projection columns, which are shared with other
projections
- final Map<String, Supplier<BaseColumnHolder>> baseColumns =
readProjectionColumns(
- metadata,
- baseProjection,
- fileMapper,
- Map.of(),
- intervalStartMillis,
- lazy,
- loadFailed
- );
+
+ // For clustered base tables the columns are always accessed through
cluster groups, skip reading any base
+ // columns so we don't try to map files that don't exist
+ final boolean isClusteredSummary = baseSchema instanceof
ClusteredValueGroupsBaseTableSchema;
+ final ClusteredValueGroupsBaseTableSchema clusteredBaseSummary;
+ final Map<String, Supplier<BaseColumnHolder>> baseColumns;
+ if (isClusteredSummary) {
+ clusteredBaseSummary = (ClusteredValueGroupsBaseTableSchema)
baseSchema;
+ if (clusteredBaseSummary.getSharedColumns().isEmpty()) {
Review Comment:
yea, they are not wired up and cannot be used in this PR, this is just
scaffolding and a forceful check to fix it once they get wired up "soon". I
suppose i can remove until i add it later, but i was planning on this to be a
near term follow-up so was just going ahead and putting all of the metadata in
place to be ready later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
