pirvtech commented on PR #19138: URL: https://github.com/apache/druid/pull/19138#issuecomment-4985736572
> > @pirvtech , the test failures seem genuine. Also, there are 2 open comments. > > Please try to get these resolved soon if this patch needs to be included in Druid 38. > > Error seems to be about missing @Inject annotation on the TimelineConfig constructor. Not sure why guice is looking for the @Inject annotation on the single arg constructor or requiring a default constructor. The class is registered using JsonConfigProvider with the guice binder, and the JsonConfigProvider should be able to use the single arg connector as it has the @JsonCreator annotation on it. This seems to be ok for KafkaEmitterConfig. Figured why this is happening and added a default constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
