kfaraz commented on code in PR #19138:
URL: https://github.com/apache/druid/pull/19138#discussion_r3592566717


##########
server/src/main/java/org/apache/druid/segment/indexing/SegmentTimelineConfig.java:
##########
@@ -24,13 +24,27 @@
 
 import javax.annotation.Nullable;
 
-public class TimelineConfig
+/**
+ * Configuration settings related to segment timeline management
+ */
+public class SegmentTimelineConfig
 {
+  /**
+   * Use an indexing mechanism based on an interval tree for organizing 
segments in memory that leads to faster search
+   */
   @JsonProperty
   private final boolean fastIntervalSearch;
 
+  // Default constructor in cases where the class is not being constructed 
from JSON properties (such as direct
+  // injection from Guice without the JsonConfigProvider)

Review Comment:
   Where is it being injected by Guice directly?
   We should not support this mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to