FrankChen021 commented on code in PR #19792:
URL: https://github.com/apache/druid/pull/19792#discussion_r3682713481
##########
server/src/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java:
##########
@@ -368,8 +368,10 @@ private List<Interval> findInitialSearchInterval(
last.getInterval().getEnd(),
skipOffset
);
- final List<Interval> allSkipIntervals
- = sortAndAddSkipIntervalFromLatest(latestSkipInterval, skipIntervals);
+ final List<Interval> allSkipIntervals =
JodaUtils.condenseIntervals(Iterables.concat(
+ skipIntervals,
Review Comment:
[P1] Honor configured skips in coordinator compaction
This list only contains caller-provided intervals. The supervisor template
adds `config.getSkipIntervals()`, but the supported Coordinator duty uses
`PriorityBasedCompactionSegmentIterator`, which passes only locked or
running-task intervals. When supervisors are disabled, including the
older-Overlord fallback, configured `skipIntervals` are silently ignored and
excluded data can still be compacted. Merge the config intervals in the shared
or coordinator path and add legacy-duty coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
