FrankChen021 commented on code in PR #19792:
URL: https://github.com/apache/druid/pull/19792#discussion_r3690774894
##########
server/src/main/java/org/apache/druid/server/compaction/DataSourceCompactibleSegmentIterator.java:
##########
@@ -368,8 +368,10 @@ private List<Interval> findInitialSearchInterval(
last.getInterval().getEnd(),
skipOffset
);
- final List<Interval> allSkipIntervals
- = sortAndAddSkipIntervalFromLatest(latestSkipInterval, skipIntervals);
+ final List<Interval> allSkipIntervals =
JodaUtils.condenseIntervals(Iterables.concat(
+ skipIntervals,
Review Comment:
Confirmed resolved: the shared iterator now merges
`config.getSkipIntervals()`, so the Coordinator and legacy fallback path honors
configured skips even without external lock intervals. The new policy test
covers this path.
Reviewed 15 of 15 changed files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
