capistrant commented on code in PR #19843:
URL: https://github.com/apache/druid/pull/19843#discussion_r3705449263
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/CloneHistoricals.java:
##########
@@ -150,6 +182,41 @@ private void loadSegmentOnTargetServer(
}
}
+ /**
+ * Returns the clone target to a full load of {@code segment}, for when the
source has stopped holding it partially.
+ * <p>
+ * A plain load request on top of the existing replica does not achieve
this. A historical that receives an unwrapped
+ * load request for a segment it already holds under a partial-load rule
keeps that rule applied: its holds go on
Review Comment:
yes, this was me trying to keep the change clone related only. latest branch
attempts to make load() properly handle this transition in load profile, which
simplifies the clone handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
