capistrant commented on code in PR #19843:
URL: https://github.com/apache/druid/pull/19843#discussion_r3706954800
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/PartialLoadProfile.java:
##########
@@ -93,6 +96,37 @@ public static PartialLoadProfile forLoaded(Map<String,
Object> wrappedLoadSpec,
return intern(new PartialLoadProfile(wrappedLoadSpec, fingerprint,
loadedBytes));
}
+ /**
+ * This profile in request form for {@code segment}, for reissuing to
another server the same partial load that
+ * produced it (clone catch-up, balancer move). Two things are normalized:
+ * <ul>
+ * <li>{@code loadedBytes} is dropped. A profile read back off a server
carries the footprint that server
+ * realized, which belongs to that server's announcement and not to a
request.</li>
+ * <li>The wrapper's {@link PartialLoadSpec#DELEGATE_FIELD} is replaced
with {@code segment}'s load spec. The
+ * wrapper was built when the source server was asked to load, so it
carries whatever deep-storage location
Review Comment:
I think you are right. got talked into needing to be defensive by an agent
review who convinced me I could be handing back a stale request. But I cannot
find evidence that it could possibly be stale so it looks to me like useless
behavior. will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
