kfaraz commented on code in PR #19772: URL: https://github.com/apache/druid/pull/19772#discussion_r3727167907
########## docs/api-reference/data-management-api.md: ########## @@ -35,15 +35,17 @@ For example, use `http://localhost:8888` for quickstart deployments. :::info - Coordinator APIs for data management are now deprecated. Use new APIs served by the Overlord instead. -- Do not use these APIs while an indexing task or kill task is in progress for the same datasource and interval. +- The APIs to mark segments as used fail if an indexing task or kill task is in progress for the same datasource and overlapping interval, to ensure that there are no accidental data losses or data inconsistencies. +- Do not use the APIs to mark segments as unused while an indexing task or kill task is in progress for the same datasource and interval. Review Comment: Yes, I will try to include the info of the locked interval in the exception that gets thrown. I will create a separate patch for the locking changes to `markUsed` as well as `markUnused` APIs. The `markUnused` would be trickier as it is frequently used by the Coordinator to delete overshadowed segments. Acquiring an EXCLUSIVE lock while the Coordinator does this is not desirable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
