Copilot commented on code in PR #19916:
URL: https://github.com/apache/druid/pull/19916#discussion_r3736338458
##########
extensions-contrib/druid-deltalake-extensions/src/test/java/org/apache/druid/delta/input/DeltaInputSourceTest.java:
##########
@@ -53,16 +53,15 @@
public class DeltaInputSourceTest
{
- @Before
+ @BeforeEach
public void setUp()
{
System.setProperty("user.timezone", "UTC");
}
- @RunWith(Parameterized.class)
- public static class TablePathParameterTests
+ @Nested
+ public class TablePathParameterTests
{
- @Parameterized.Parameters
public static Object[][] data()
{
Review Comment:
`TablePathParameterTests` is a non-static `@Nested` inner class, but it
declares `public static Object[][] data()`. Java forbids static methods in
non-static inner classes, so this won’t compile. Make the method non-static and
use a per-class test instance (or move the method to the enclosing class and
reference it via `@MethodSource`).
This issue also appears on line 187 of the same file.
##########
extensions-contrib/druid-iceberg-extensions/src/test/java/org/apache/druid/iceberg/input/IcebergInputSourceTest.java:
##########
@@ -64,8 +63,8 @@
public class IcebergInputSourceTest
{
- @Rule
- public TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @TempDir
+ public File temporaryFolder;
Review Comment:
`temporaryFolder` is declared as a `@TempDir` field but is never referenced.
Leaving it in place needlessly creates a temp directory for each test run and
also requires the `TempDir` import. Either use this directory in the test setup
or remove the unused field/import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
