FrankChen021 commented on code in PR #19916:
URL: https://github.com/apache/druid/pull/19916#discussion_r3736541733
##########
extensions-contrib/druid-iceberg-extensions/src/test/java/org/apache/druid/iceberg/input/IcebergInputSourceTest.java:
##########
@@ -64,8 +63,8 @@
public class IcebergInputSourceTest
{
- @Rule
- public TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @TempDir
+ public File temporaryFolder;
Review Comment:
Thanks for flagging this. No update is needed for this migration:
`temporaryFolder` is unused in both the base and head versions, and the change
only converts the pre-existing JUnit 4 `TemporaryFolder` rule to JUnit 5
`@TempDir`. Removing it is optional cleanup, so it is intentionally left
unchanged.
##########
extensions-contrib/druid-deltalake-extensions/src/test/java/org/apache/druid/delta/input/DeltaInputSourceTest.java:
##########
@@ -53,16 +53,15 @@
public class DeltaInputSourceTest
{
- @Before
+ @BeforeEach
public void setUp()
{
System.setProperty("user.timezone", "UTC");
}
- @RunWith(Parameterized.class)
- public static class TablePathParameterTests
+ @Nested
+ public class TablePathParameterTests
{
- @Parameterized.Parameters
public static Object[][] data()
{
Review Comment:
Thanks for flagging this. No update is needed: the `data()` factory is
carried over from the base test, and Druid targets Java 25, where static
members in inner classes are permitted. The cited pre-Java-16 restriction
therefore does not apply, and this static `@MethodSource` is valid as written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
