FrankChen021 commented on code in PR #19886:
URL: https://github.com/apache/druid/pull/19886#discussion_r3740842758
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryVirtualStorageTest.java:
##########
@@ -207,7 +207,10 @@ void testQueryPartials()
Assertions.assertEquals(expectedResults[3],
Long.parseLong(cluster.runSql(queries[3], dataSource)));
assertQueryMetrics(4, expectedLoads[3]);
- emitter.waitForNextEvent(event ->
event.hasMetricName(StorageMonitor.VSF_LOAD_BEGIN_COUNT));
+ emitter.waitForEventAggregate(
Review Comment:
[P2] Baseline flush is not a full monitor barrier
The baseline only quiesces VSF_LOAD_BEGIN_COUNT, but StorageMonitor emits
read and eviction metrics afterward and can continue recording them after
load-begin activity stops. flush() may therefore allow late pre-query events to
satisfy these aggregate waits, so positive assertions can pass before the
1000-query activity is observed. Wait for a terminal metric or complete monitor
tick and make the flush boundary atomic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
