FrankChen021 commented on code in PR #19921:
URL: https://github.com/apache/druid/pull/19921#discussion_r3749651300
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/duty/UnusedSegmentsKiller.java:
##########
@@ -474,7 +473,10 @@ private EmbeddedKillTask(
candidate.dataSource(),
candidate.interval(),
null,
- Map.of(Tasks.PRIORITY_KEY,
Tasks.DEFAULT_EMBEDDED_KILL_TASK_PRIORITY),
+ Map.of(
+ Tasks.PRIORITY_KEY, Tasks.DEFAULT_EMBEDDED_KILL_TASK_PRIORITY,
+ Tasks.TASK_LOCK_TYPE, TaskLockType.KILL.name()
Review Comment:
[P2] KILL locks incorrectly suppress compaction
The compaction duty reports active locks through getLockedIntervals, which
includes this priority-25 KILL lock even though KILL is designed to coexist
with compaction locks. Compatible intervals are consequently deferred while a
kill task is active. Make lock reporting honor lock compatibility and add a
regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
