FrankChen021 commented on code in PR #19922:
URL: https://github.com/apache/druid/pull/19922#discussion_r3758126077
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java:
##########
@@ -113,9 +116,11 @@ public class TaskQueueTest extends IngestionTestBase
private StubServiceEmitter serviceEmitter;
private Map<String, Object> defaultTaskContext;
+ @BeforeEach
@Override
public void setUpIngestionTestBase() throws IOException
{
+ derbyConnectorRule.before();
Review Comment:
[P1] Double-starts the inherited Derby fixture
At this head, IngestionTestBase.setUpIngestionTestBase() already calls
derbyConnectorRule.before(); this override calls it once before super, so super
replaces the connector with a second in-memory database and leaks the first.
super.tearDownIngestionTestBase() likewise already calls after(), while this
override calls it again at line 159. TestDerbyConnector.tearDown() is not
idempotent, so the second drop can fail these tests. Remove the explicit Derby
calls from both TaskQueueTest and TaskQueueConcurrencyTest, or make one layer
own the lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
