FrankChen021 opened a new pull request, #19981: URL: https://github.com/apache/druid/pull/19981
Fixes #13948. ### Description Migrate Batch 3 processing tests to the current JUnit 5 APIs while preserving test behavior and compatibility. This covers segment core, serialization, incremental indexes, and the index-merger hierarchy. The migration uses `TemporaryFolderExtension`, `CloserExtension`, and `LoggerCaptureExtension`, retains the existing `CloserRule` compatibility test, and preserves the shared `DruidExceptionMatcher` and `ExceptionMatcher` APIs. ### Scope - `processing/src/test/java/org/apache/druid/segment` core and index-merger tests - `segment/column`, `segment/data`, `segment/generator`, `segment/incremental`, `segment/serde`, `segment/shim`, `segment/transform`, `segment/vector`, and `segment/writeout` - No query files, shared helper changes, Batch 2 paths, `CloserRule.java`, or `processing/pom.xml` changes ### Validation - `mvn -ntp -pl processing -am test-compile -Dweb.console.skip=true -T1C` — passed with Checkstyle, PMD, forbidden APIs, enforcer, and compilation checks - `mvn -ntp -pl processing spotbugs:check -Dweb.console.skip=true` — passed with 0 bugs and 0 errors (SpotBugs reported one missing optional `MarkerManager` class during analysis) - Focused Batch 3 migration tests — 112 tests passed, 0 failures, 1 intentionally disabled - `git diff --check` and scope audits — passed The broader parameterized Schemaless run was not stable on the local OpenJDK 25 environment: it reproduced intermittent direct-buffer `Unsafe` SIGSEGVs and two parameterized-instance flakes that also occurred when the class was run in isolation. No source assertion failure was isolated. ### Key changed/added classes in this PR - Segment core and index-merger tests - Column, data, incremental-index, serde, transform, vector, and writeout tests - `CloserRuleTest` compatibility coverage This PR has: - [x] been self-reviewed. - [x] added or updated unit tests (existing tests migrated while preserving coverage). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
