FrankChen021 commented on code in PR #19981:
URL: https://github.com/apache/druid/pull/19981#discussion_r3766624989
##########
processing/src/test/java/org/apache/druid/segment/QueryableIndexColumnCapabilitiesTest.java:
##########
@@ -61,15 +61,15 @@
public class QueryableIndexColumnCapabilitiesTest extends
InitializedNullHandlingTest
{
- @ClassRule
- public static TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @RegisterExtension
+ public static TemporaryFolderExtension temporaryFolder = new
TemporaryFolderExtension();
Review Comment:
[P1] Static fixture directory is deleted after each test
TemporaryFolderExtension deletes its root in afterEach, but this static
registration builds shared mmap indexes in @BeforeAll and closes them only in
@AfterAll. Later tests therefore use indexes whose backing files were removed;
the same pattern exists in UnnestCursorFactoryTest. Use class-scoped cleanup or
skip per-test deletion for static registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
