FrankChen021 commented on code in PR #19975:
URL: https://github.com/apache/druid/pull/19975#discussion_r3766627827


##########
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java:
##########
@@ -264,6 +264,9 @@ private int submitCompactionTasks(
       } else if (compactionStatus.isSkipped()) {
         snapshotBuilder.addToSkipped(candidatesWithStatus);
         continue;
+      } else if (compactionStatus.isPolicyExcluded()) {

Review Comment:
   [P2] Policy-excluded candidates remain pending after slots fill
   
   This branch only classifies candidates reached before task slots are 
exhausted. The remaining iterator entries are later unconditionally counted as 
pending, so policy-rejected intervals are reported as awaiting compaction when 
slots are constrained or unavailable. Classify the remainder against the policy 
and add a mixed eligible/rejected slot test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to