capistrant commented on code in PR #19975: URL: https://github.com/apache/druid/pull/19975#discussion_r3778546580
########## server/src/main/java/org/apache/druid/server/compaction/CompactionSkipReason.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.compaction; + +/** + * Stable code identifying why an interval was not compacted in a run. Reported + * as a dimension on the {@code skipCompact} metrics and as the breakdown of + * skipped stats in {@code AutoCompactionSnapshot}, so the name of a constant + * must not change once released. + * <p> + * Every reason has a {@link Category} which tells a consumer how to treat the + * interval without having to know the individual reasons. Consumers must switch + * on the category rather than on the reason so that reasons added later are + * handled correctly by default. Review Comment: ```suggestion * interval without having to know the individual reasons. Consumers can switch * on the category rather than on the reason so that reasons added later are * are automatically folded in. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
