vogievetsky commented on a change in pull request #7292: Add table column
selection in druid console to allow hiding/showing of columns
URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266719009
##########
File path: web-console/src/views/segments-view.tsx
##########
@@ -133,8 +138,26 @@ export class SegmentsView extends
React.Component<SegmentsViewProps, SegmentsVie
});
}
+ private initTableColumnSelection() {
+ if (localStorage.getItem(segmentTableColumnSelection) == null) {
+ const columns: string[] = ["Segment ID", "Datasource", "Start", "End",
"Version", "Partition",
Review comment:
It is really nasty that you repeat the columns here, columns should only be
defined in one place the table column definitions. You should extract the table
columns into their own `const` and then map out the values via some util
function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
