vogievetsky commented on a change in pull request #7292: Add table column
selection in druid console to allow hiding/showing of columns
URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r266719143
##########
File path: web-console/src/views/segments-view.tsx
##########
@@ -155,15 +178,17 @@ export class SegmentsView extends
React.Component<SegmentsViewProps, SegmentsVie
{
Header: "Segment ID",
accessor: "segment_id",
- width: 300
+ width: 300,
+ show: tableColumnSelection["Segment ID"]
Review comment:
It looks like if a column is added in a future PR it will be default not
shown. You should flip the entire script and only store the hidden columns and
show columns unless they are hidden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
