FrankChen021 commented on code in PR #19814:
URL: https://github.com/apache/druid/pull/19814#discussion_r3924869310
##########
website/package.json:
##########
@@ -39,5 +39,13 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"replace-in-file": "^4.3.1"
+ },
+ "overrides": {
+ "brace-expansion": "5.0.8",
Review Comment:
[P2] Avoid the incompatible brace-expansion override
This global override forces brace-expansion 5.0.8 onto [email protected],
which is still installed and calls require("brace-expansion") as a function.
The v5 package exposes named exports instead, so brace-pattern matching can
fail with "expand is not a function" in consumers of minimatch 3. Scope the
override to compatible consumers or upgrade the affected minimatch dependency
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
