clintropolis opened a new pull request, #20267:
URL: https://github.com/apache/druid/pull/20267

   ### Description
   Updates `PartialSegmentStatusInTier` and `StrategicSegmentAssigner` to 
prefer in-place reloads of partial segments rather than load-then-drop to an 
empty server. The reason it was like this is because partial load rules were 
introduced before historicals could actually honor them, and my design at the 
time meant that they would only do an additive load on rule change; however the 
functionality that got actually merged ended up having the rules using internal 
holds on the weak references that make up a partially loaded segment in cache, 
so a rule change is not just additive (we load any missing bundles, and release 
the holds on any bundles no longer pinned by rules, allowing them to be 
evicted). This means that there is no downside to doing an in-place reload 
since it only has to download the difference rather than the whole set, so this 
PR flips the priority to do fresh load as the fallback behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to