github-advanced-security[bot] commented on code in PR #20267:
URL: https://github.com/apache/druid/pull/20267#discussion_r3939217515


##########
server/src/main/java/org/apache/druid/server/coordinator/loading/PartialSegmentStatusInTier.java:
##########
@@ -119,19 +122,19 @@
   }
 
   /**
-   * Stale-loaded servers that can take an additive reload request; kept as a 
subset of {@link #getStaleLoaded()}
-   * filtered for decommissioning / load-queue-full, so the algorithm can 
target them as a fallback destination when
-   * no fresh-load slots are available. See {@code 
StrategicSegmentAssigner.updateReplicasInTierPartial}.
+   * Stale-loaded servers that can take an in-place reload request; a subset 
of {@link #getStaleLoaded()} filtered by
+   * {@link #canReloadInPlace}. The preferred destination for a matching 
deficit, ahead of
+   * {@link #getEligibleForFreshLoad()}. See {@link 
StrategicSegmentAssigner#updateReplicasInTierPartial}.
    */
-  public List<ServerHolder> getEligibleForAdditiveReload()
+  public List<ServerHolder> getEligibleForInPlaceReload()

Review Comment:
   ## CodeQL / Exposing internal representation
   
   getEligibleForInPlaceReload exposes the internal representation stored in 
field eligibleForInPlaceReload. The value may be modified [after this call to 
getEligibleForInPlaceReload](1).
   
   [Show more 
details](https://github.com/apache/druid/security/code-scanning/11935)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to