Copilot commented on code in PR #20271:
URL: https://github.com/apache/druid/pull/20271#discussion_r3946614301
##########
pom.xml:
##########
@@ -2048,6 +2048,7 @@
<!-- locale settings must be set on the command line
before startup -->
<!-- set default options -->
<argLine>
+ -XX:+UseCompactObjectHeaders
@{jacocoArgLine}
${jdk.strong.encapsulation.argLine}
Review Comment:
PR description mentions enabling compact headers in the processing
`benchmark` profile that overrides test JVM args, but `processing/pom.xml`
still has a `benchmark` profile `<argLine>` that does not include
`-XX:+UseCompactObjectHeaders`, so benchmark runs would not actually exercise
compact headers. Either add the flag there or avoid overriding the parent
`argLine` so it inherits this setting.
##########
.github/workflows/docker-tests.yml:
##########
@@ -26,7 +26,12 @@ jobs:
- name: Set Docker image env var
run: echo "DRUID_DIST_IMAGE_NAME=apache/druid:docker-tests" >>
$GITHUB_ENV
- name: Build the Docker image
- run: DOCKER_BUILDKIT=1 docker build -t $DRUID_DIST_IMAGE_NAME -f
distribution/docker/Dockerfile .
+ run: |
+ # Enable compact headers in the test image for services and task
JVMs, including K3s pods.
+ {
+ cat distribution/docker/Dockerfile
+ printf '\nENV JAVA_TOOL_OPTIONS="-XX:+UseCompactObjectHeaders"\n'
+ } | DOCKER_BUILDKIT=1 docker build -t "$DRUID_DIST_IMAGE_NAME" -f - .
Review Comment:
The workflow uses a pipeline to stream a modified Dockerfile into `docker
build`, but without `set -o pipefail` a failure in `cat
distribution/docker/Dockerfile` (or `printf`) would not fail the step because
the pipeline exit status is that of `docker build`. Add `set -o pipefail` so
missing/invalid Dockerfile input causes the job to fail fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
