FrankChen021 commented on code in PR #20271:
URL: https://github.com/apache/druid/pull/20271#discussion_r3947208972
##########
.github/workflows/docker-tests.yml:
##########
@@ -26,7 +26,12 @@ jobs:
- name: Set Docker image env var
run: echo "DRUID_DIST_IMAGE_NAME=apache/druid:docker-tests" >>
$GITHUB_ENV
- name: Build the Docker image
- run: DOCKER_BUILDKIT=1 docker build -t $DRUID_DIST_IMAGE_NAME -f
distribution/docker/Dockerfile .
+ run: |
+ # Enable compact headers in the test image for services and task
JVMs, including K3s pods.
+ {
+ cat distribution/docker/Dockerfile
+ printf '\nENV JAVA_TOOL_OPTIONS="-XX:+UseCompactObjectHeaders"\n'
+ } | DOCKER_BUILDKIT=1 docker build -t "$DRUID_DIST_IMAGE_NAME" -f - .
Review Comment:
Addressed in the latest commit: the Docker image build step now runs `set -o
pipefail` before the pipeline, so failures while generating the streamed
Dockerfile cannot be hidden by the `docker build` exit status.
##########
pom.xml:
##########
@@ -2048,6 +2048,7 @@
<!-- locale settings must be set on the command line
before startup -->
<!-- set default options -->
<argLine>
+ -XX:+UseCompactObjectHeaders
@{jacocoArgLine}
${jdk.strong.encapsulation.argLine}
Review Comment:
The benchmark-profile concern is intentional and now reflected in the PR
description. The compact-header flag is scoped to unit, embedded, and Docker
tests; the processing benchmark profile is not part of CI, so it remains
unchanged. I removed the stale benchmark-profile wording from the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
