FrankChen021 commented on code in PR #20297: URL: https://github.com/apache/druid/pull/20297#discussion_r3958143723
########## .github/scripts/run_docker-tests: ########## @@ -35,4 +35,5 @@ fi # No snapshot updates OPTS+=" -nsu" -mvn -B -pl embedded-tests -am $OPTS verify -Pdocker-tests,skip-static-checks -DskipUTs -D$DRUID_IMAGE_SYS_PROPERTY=$DRUID_IMAGE_NAME "-DjfrProfilerArgLine=$JFR_PROFILER_ARG_LINE" "$@" +# build-dist has already installed the reactor artifacts in the local repository. +mvn -B -pl embedded-tests $OPTS verify -Pdocker-tests,skip-static-checks -DskipUTs -D$DRUID_IMAGE_SYS_PROPERTY=$DRUID_IMAGE_NAME "-DjfrProfilerArgLine=$JFR_PROFILER_ARG_LINE" "$@" Review Comment: [P1] Do not drop the reactor build before resolving web-console With the new persisted Maven build cache, a cache hit can restore the web-console build and skip its maven-install-plugin execution; this repository has no executionControl/runAlways configuration for install. The following invocation now selects only embedded-tests, but embedded-tests/pom.xml has an unconditional test-scoped org.apache.druid:web-console dependency. On a fresh runner, or after setup-java invalidates its ~/.m2/repository cache, that SNAPSHOT is not available in the local repository and the Docker-test job fails during dependency resolution. Keep -am here or explicitly install the restored web-console artifact before this non-reactor invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
