FrankChen021 commented on code in PR #20297:
URL: https://github.com/apache/druid/pull/20297#discussion_r3974773921
##########
.github/scripts/run_docker-tests:
##########
@@ -35,4 +35,7 @@ fi
# No snapshot updates
OPTS+=" -nsu"
-mvn -B -pl embedded-tests -am $OPTS verify -Pdocker-tests,skip-static-checks
-DskipUTs -D$DRUID_IMAGE_SYS_PROPERTY=$DRUID_IMAGE_NAME
"-DjfrProfilerArgLine=$JFR_PROFILER_ARG_LINE" "$@"
+# build-dist has already installed every reactor module into the local Maven
+# repository in this job, so only embedded-tests needs to be built here.
+# Building with -am would re-run the whole reactor (including web-console)
again.
+mvn -B -pl embedded-tests $OPTS verify -Pdocker-tests,skip-static-checks
-DskipUTs -D$DRUID_IMAGE_SYS_PROPERTY=$DRUID_IMAGE_NAME
"-DjfrProfilerArgLine=$JFR_PROFILER_ARG_LINE" "$@"
Review Comment:
Superseded by 6dbbcc662c. The persisted build-cache restore/save steps were
removed from the workflow, so a build-cache hit cannot occur in this job:
`~/.m2/build-cache` is empty on every fresh runner (setup-java caches only
`~/.m2/repository`), and `build-dist` runs the full lifecycle including
`install` for every module. The latest run confirms web-console was a cache
miss ("Local build was not found by checksum") and
`web-console-39.0.0-SNAPSHOT.jar` was installed before `run_docker-tests` ran.
`-am` is therefore dropped (saves ~1m45s), and the comment in the script
documents the invariant. If a persisted build cache is reintroduced later,
`-am` must come back, or a `.mvn/maven-build-cache-config.xml` with `runAlways`
for `maven-install-plugin` must be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
