FrankChen021 commented on code in PR #18525:
URL: https://github.com/apache/druid/pull/18525#discussion_r3986354281


##########
processing/src/main/java/org/apache/druid/segment/incremental/RowIngestionMetersTotals.java:
##########
@@ -44,32 +45,66 @@ public RowIngestionMetersTotals(
       @JsonProperty("processedWithError") long processedWithError,
       @JsonProperty("thrownAway") long thrownAway,
       @JsonProperty("thrownAwayByReason") @Nullable Map<String, Long> 
thrownAwayByReason,
-      @JsonProperty("unparseable") long unparseable
+      @JsonProperty("unparseable") long unparseable,
+      @JsonProperty("filtered") long filtered

Review Comment:
   No such case. Ignore this. AI is too conservative



##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaIndexTaskIOConfig.java:
##########
@@ -66,7 +68,8 @@ public KafkaIndexTaskIOConfig(
       @JsonProperty("configOverrides") @Nullable KafkaConfigOverrides 
configOverrides,
       @JsonProperty("multiTopic") @Nullable Boolean multiTopic,
       @JsonProperty("refreshRejectionPeriodsInMinutes") Long 
refreshRejectionPeriodsInMinutes,
-      @JsonProperty("boundedStreamConfig") @Nullable BoundedStreamConfig 
boundedStreamConfig
+      @JsonProperty("boundedStreamConfig") @Nullable BoundedStreamConfig 
boundedStreamConfig,
+      @JsonProperty("headerBasedFilterConfig") @Nullable 
KafkaHeaderBasedFilterConfig headerBasedFilterConfig

Review Comment:
   No such case. Ignore this. AI is too conservative



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to