FrankChen021 commented on code in PR #18525:
URL: https://github.com/apache/druid/pull/18525#discussion_r4062926472
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java:
##########
@@ -105,6 +105,9 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.setMetric("ingest/events/processed",
rowIngestionMetersTotals.getProcessed() -
previousRowIngestionMetersTotals.getProcessed()));
+ final long filtered = rowIngestionMetersTotals.getFiltered() -
previousRowIngestionMetersTotals.getFiltered();
+ emitter.emit(builder.setMetric("ingest/events/filtered", filtered));
Review Comment:
I rechecked the current head `553fd6f0666a3129e5134a58e375ad67d1a8a8b8`
after the “addressed” reply. The head has not changed since the original
review, and this path still reuses the same `ServiceMetricEvent.Builder`: it
sets `DruidMetrics.REASON` for thrown-away-by-reason events, then emits
`ingest/events/filtered` without clearing that dimension. I’m keeping this as
the only active finding in the corrected summary; please push the corresponding
code change or point me to a different current head for reassessment.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
