Shekharrajak commented on code in PR #19510:
URL: https://github.com/apache/druid/pull/19510#discussion_r3994726562
##########
extensions-contrib/druid-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/IcebergArrowInputSourceReader.java:
##########
@@ -158,6 +159,21 @@ private void validateNoDeleteFiles(final TableScan scan)
throws IOException
}
}
+ private void validateDecimalPrecision(final TableScan scan)
+ {
+ for (final Types.NestedField field : scan.schema().columns()) {
+ if (field.type().typeId() == Type.TypeID.DECIMAL
+ && ((Types.DecimalType) field.type()).precision() > 18) {
+ throw DruidException.forPersona(DruidException.Persona.USER)
+ .ofCategory(DruidException.Category.UNSUPPORTED)
+ .build(
+ "Arrow reader does not support decimal fields
with precision greater than 18. "
+ + "Use the standard Iceberg reader."
Review Comment:
We will see this usecase and try to support these scenarios in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
