aho135 commented on PR #20387: URL: https://github.com/apache/druid/pull/20387#issuecomment-5765725012
### On the `coverage-jacoco` check The one remaining red check is diff line coverage (`33% (1/3)`, required `50%`) on the 3 new guard lines in `SeekableStreamSupervisor.createNewTasks()`. This is a per-module JaCoCo artifact, not an untested change. The guard's behavior is covered by `KafkaSupervisorTest#testBoundedStreamConfig_completedGroup_doesNotTopUpReplicas` (added in this PR, passing), but that test lives in `extensions-core/kafka-indexing-service` while the guarded code is in `indexing-service`. Diff coverage is computed per module, so the cross-module coverage isn't attributed to `indexing-service`. The only new line counted as covered is the `if` condition (exercised by existing non-bounded supervisor tests); the `log.debug` + `continue` inside the guard only execute in bounded mode, which is driven from the Kafka module. Requesting a diff-coverage waiver on this basis. If a committer would rather have it covered in-module, I'm happy to add an equivalent bounded-mode test in `SeekableStreamSupervisorStateTest` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
