abhishekrb19 commented on code in PR #20387:
URL: https://github.com/apache/druid/pull/20387#discussion_r4084350369
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -2961,6 +2961,129 @@ public void
testComputeUnassignedServerPriorities_whenMultipleReplicasPerPriorit
verifyAll();
}
+ /**
+ * In bounded mode, a task group whose committed offsets have reached the
configured end must not have replacement
+ * replicas created for it. Without the guard in {@code createNewTasks()}'s
replica top-up loop, {@code replicas >
+ * tasks} would submit a replacement replica whose start offset is already
at the bounded end, so it completes
+ * instantly and re-triggers the top-up, churning tasks endlessly.
+ *
Review Comment:
The javadoc on this test explaining the fix can probably be
simplified/removed since its already covered in the relevant main code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
