github-advanced-security[bot] commented on code in PR #20379:
URL: https://github.com/apache/druid/pull/20379#discussion_r4308920062
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskTest.java:
##########
@@ -2272,6 +2611,110 @@
.build();
}
+ /**
+ * A segment whose index reports the given projections and nothing else, so
only projection analysis does any work.
+ */
+ private static Pair<DataSegment,
java.util.function.Supplier<ResourceHolder<QueryableIndex>>>
segmentWithProjections(
+ Interval interval,
+ String... projectionNames
+ )
+ {
+ final List<AggregateProjectionMetadata> projectionMetadata = new
ArrayList<>();
+ for (String projectionName : projectionNames) {
+ projectionMetadata.add(
+ new AggregateProjectionMetadata(
+ new AggregateProjectionSchema(
+ projectionName,
+ null,
+ null,
+ null,
+ ImmutableList.of("string_dim_0"),
+ new AggregatorFactory[]{new CountAggregatorFactory("cnt")},
+ ImmutableList.of(OrderBy.ascending("string_dim_0"))
+ ),
+ 1
+ )
+ );
+ }
+
+ final ColumnFormat columnFormat = Mockito.mock(ColumnFormat.class);
+
Mockito.lenient().when(columnFormat.getColumnSchema(ArgumentMatchers.anyString()))
+ .thenAnswer(invocation -> new
StringDimensionSchema(invocation.getArgument(0)));
+ final BaseColumnHolder columnHolder = Mockito.mock(BaseColumnHolder.class);
+
Mockito.lenient().when(columnHolder.getColumnFormat()).thenReturn(columnFormat);
+
+ final QueryableIndex projectionIndex = Mockito.mock(QueryableIndex.class);
+
Mockito.lenient().when(projectionIndex.getColumnHolder(ArgumentMatchers.anyString())).thenReturn(columnHolder);
+
+ final QueryableIndex index = Mockito.mock(QueryableIndex.class);
+ Mockito.lenient().when(index.getMetadata())
+ .thenReturn(new Metadata(null, null, null, null, null, null,
projectionMetadata, null));
+ Mockito.lenient().when(index.getOrdering()).thenReturn(ImmutableList.of());
+ Mockito.lenient().when(index.getAvailableDimensions()).thenReturn(new
ListIndexed<>());
+
Mockito.lenient().when(index.getProjectionQueryableIndex(ArgumentMatchers.anyString())).thenReturn(projectionIndex);
+
+ final DataSegment segment = DataSegment.builder()
+ .dataSource(DATA_SOURCE)
+ .interval(interval)
+ .version("version")
+ .size(SEGMENT_SIZE_BYTES)
+ .build();
+ return Pair.of(segment, () -> new ReferenceCountingResourceHolder<>(index,
() -> {}));
+ }
+
+ /**
+ * A clustered segment with one cluster group, shaped the way {@code
SimpleQueryableIndex} builds one: the group
+ * sub-index advertises only its own columns and ordering, while the
clustering column resolves through the constant
+ * column holder injected into it. The full column list and ordering live on
the segment-level clustered schema.
+ */
+ private static Pair<DataSegment,
java.util.function.Supplier<ResourceHolder<QueryableIndex>>> clusteredSegment(
+ Interval interval
+ )
+ {
+ final ColumnFormat columnFormat = Mockito.mock(ColumnFormat.class);
+
Mockito.lenient().when(columnFormat.getColumnSchema(ArgumentMatchers.anyString()))
+ .thenAnswer(invocation -> new
StringDimensionSchema(invocation.getArgument(0)));
+ final BaseColumnHolder columnHolder = Mockito.mock(BaseColumnHolder.class);
+
Mockito.lenient().when(columnHolder.getColumnFormat()).thenReturn(columnFormat);
+
+ final QueryableIndex groupIndex = Mockito.mock(QueryableIndex.class);
+ Mockito.lenient().when(groupIndex.getAvailableDimensions()).thenReturn(new
ListIndexed<>("value"));
+ Mockito.lenient().when(groupIndex.getOrdering())
+
.thenReturn(ImmutableList.of(OrderBy.ascending(ColumnHolder.TIME_COLUMN_NAME),
OrderBy.ascending("value")));
+
Mockito.lenient().when(groupIndex.getColumnHolder(ArgumentMatchers.anyString())).thenReturn(columnHolder);
+ Mockito.lenient().when(groupIndex.getColumnCapabilities("value"))
+
.thenReturn(ColumnCapabilitiesImpl.createDefault().setType(ColumnType.STRING).setHasMultipleValues(true));
+ Mockito.lenient().when(groupIndex.getColumnCapabilities("tenant"))
+
.thenReturn(ColumnCapabilitiesImpl.createDefault().setType(ColumnType.STRING).setHasMultipleValues(false));
+
+ final TableClusterGroupSpec group =
Mockito.mock(TableClusterGroupSpec.class);
+ final ClusteredValueGroupsBaseTableSchema clusteredBaseTable =
+ Mockito.mock(ClusteredValueGroupsBaseTableSchema.class);
+
Mockito.lenient().when(clusteredBaseTable.getClusterGroups()).thenReturn(ImmutableList.of(group));
+ final List<OrderBy> segmentOrdering = ImmutableList.of(
+ OrderBy.ascending("tenant"),
+ OrderBy.ascending(ColumnHolder.TIME_COLUMN_NAME),
+ OrderBy.ascending("value")
+ );
+
Mockito.lenient().when(clusteredBaseTable.getOrdering()).thenReturn(segmentOrdering);
+
Mockito.lenient().when(clusteredBaseTable.getDimensionNames()).thenReturn(ImmutableList.of("tenant",
"value"));
+
+ final QueryableIndex index = Mockito.mock(QueryableIndex.class);
+ Mockito.lenient().when(index.getMetadata())
+ .thenReturn(new Metadata(null, null, null, null, null, null, null,
clusteredBaseTable));
+ Mockito.lenient()
+ .when(index.getClusterGroupQueryableIndex(ArgumentMatchers.any(),
ArgumentMatchers.anyBoolean()))
+ .thenReturn(groupIndex);
+
+ final DataSegment segment = DataSegment.builder()
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [DataSegment.builder](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/12108)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
