capistrant commented on code in PR #20379:
URL: https://github.com/apache/druid/pull/20379#discussion_r4330150120
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -996,38 +1000,38 @@ private static List<DimensionSchema> undeclaredColumns(
DimensionsSpec analyzed
)
{
- final Set<String> declared = new HashSet<>();
- for (DimensionSchema declaredColumn :
baseTable.getDimensionsSpec().getDimensions()) {
- declared.add(declaredColumn.getName());
- }
+ final Set<String> declared = declaredColumnNames(baseTable);
return analyzed.getDimensions()
.stream()
.filter(dimension ->
!declared.contains(dimension.getName()))
.collect(Collectors.toList());
}
/**
- * The analyzed aggregators that {@code baseTable} does not already declare.
Aggregators recovered from segments are
- * already in combining form, which is what a rollup spec requires.
+ * The names of the columns {@code baseTable} stores, metric columns
included. A name in here is described by the
Review Comment:
`metric columns included` is this erroneous or did you mean to also collect
the metrics for the base table now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
