havefunatcode commented on issue #18010: URL: https://github.com/apache/druid/issues/18010#issuecomment-6468063857
@FrankChen021 Sorry, I wasn't clear. I only meant to reject string literals, STRING columns would keep the implicit cast. Putting the check in `Aggregations.toDruidExpressionForNumericAggregator` for literals that can't be parsed as numbers makes sense, I'll open a PR for that. One thing I ran into: SUM/MIN/MAX/AVG/COUNT/SINGLE_VALUE reach that conversion through `getArgumentsForSimpleAggregator`, and checking there breaks things like `COUNT(DISTINCT 'abc')`, so I'd leave that path out and explain it in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
