havefunatcode commented on issue #18010:
URL: https://github.com/apache/druid/issues/18010#issuecomment-6470092265
Thanks, I checked. COUNT, COUNT DISTINCT and MAX on a STRING column are
covered, SUM/MIN/AVG aren't, and none of them are tested with string literals.
I'll add a quidem test that runs all six on a STRING column, a numeric literal
(`'1.5'`) and a non-numeric one (`'abc'`), and records what they return today.
The test also shows that `SUM('abc')` and `AVG('abc')` return null instead
of failing. Calcite already turns `'abc'` into `null:DECIMAL(38, 19)` in the
logical plan, so the new check never sees the literal. I'd leave that for a
follow-up unless you want it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
