vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287164040
##########
File path: web-console/src/views/task-view/tasks-view.tsx
##########
@@ -697,59 +705,71 @@ ORDER BY "rank" DESC, "created_time" DESC`);
/>
</Menu>;
- return <div className="tasks-view app-view">
- <ViewControlBar label="Supervisors">
- <Button
- icon={IconNames.REFRESH}
- text="Refresh"
- onClick={() => this.supervisorQueryManager.rerunLastQuery()}
- />
- <Button
- icon={IconNames.PLUS}
- text="Submit supervisor"
- onClick={() => this.setState({ supervisorSpecDialogOpen: true })}
- />
- <TableColumnSelection
- columns={supervisorTableColumns}
- onChange={(column) =>
supervisorTableColumnSelectionHandler.changeTableColumnSelection(column)}
-
tableColumnsHidden={supervisorTableColumnSelectionHandler.hiddenColumns}
- />
- </ViewControlBar>
- {this.renderSupervisorTable()}
-
- <div className="control-separator"/>
-
- <ViewControlBar label="Tasks">
- <Label>Group by</Label>
- <ButtonGroup>
- <Button active={groupTasksBy === null} onClick={() =>
this.setState({ groupTasksBy: null })}>None</Button>
- <Button active={groupTasksBy === 'type'} onClick={() =>
this.setState({ groupTasksBy: 'type' })}>Type</Button>
- <Button active={groupTasksBy === 'datasource'} onClick={() =>
this.setState({ groupTasksBy: 'datasource' })}>Datasource</Button>
- <Button active={groupTasksBy === 'status'} onClick={() =>
this.setState({ groupTasksBy: 'status' })}>Status</Button>
- </ButtonGroup>
- <Button
- icon={IconNames.REFRESH}
- text="Refresh"
- onClick={() => this.taskQueryManager.rerunLastQuery()}
- />
- {
- !noSqlMode &&
- <Button
- icon={IconNames.APPLICATION}
- text="Go to SQL"
- onClick={() => goToSql(this.taskQueryManager.getLastQuery())}
- />
- }
- <Popover content={submitTaskMenu} position={Position.BOTTOM_LEFT}>
- <Button icon={IconNames.PLUS} text="Submit task"/>
- </Popover>
- <TableColumnSelection
- columns={taskTableColumns}
- onChange={(column) =>
taskTableColumnSelectionHandler.changeTableColumnSelection(column)}
- tableColumnsHidden={taskTableColumnSelectionHandler.hiddenColumns}
- />
- </ViewControlBar>
- {this.renderTaskTable()}
+ // tslint:disable-next-line:radix
Review comment:
this is not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
