vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287161036
##########
File path: web-console/src/views/servers-view/servers-view.tsx
##########
@@ -415,49 +424,58 @@ WHERE "server_type" = 'historical'`);
const { groupByTier } = this.state;
const { serverTableColumnSelectionHandler,
middleManagerTableColumnSelectionHandler } = this;
- return <div className="servers-view app-view">
- <ViewControlBar label="Historicals">
- <Button
- icon={IconNames.REFRESH}
- text="Refresh"
- onClick={() => this.serverQueryManager.rerunLastQuery()}
- />
- {
- !noSqlMode &&
+ return <SplitterLayout
+ customClassName={'servers-view app-view'}
+ vertical
+ percentage
+
secondaryInitialSize={Number(localStorageGet(LocalStorageKeys.SERVERS_VIEW_PANE_SIZE)
as string)}
+ primaryMinSize={30}
+ secondaryMinSize={30}
+ onSecondaryPaneSizeChange={this.onSecondaryPaneSizeChange}
+ >
+ <div className={'topPane'}>
+ <ViewControlBar label="Historicals">
<Button
- icon={IconNames.APPLICATION}
- text="Go to SQL"
- onClick={() => goToSql(this.serverQueryManager.getLastQuery())}
+ icon={IconNames.REFRESH}
+ text="Refresh"
+ onClick={() => this.serverQueryManager.rerunLastQuery()}
/>
- }
- <Switch
- checked={groupByTier}
- label="Group by tier"
- onChange={() => this.setState({ groupByTier: !groupByTier })}
- />
- <TableColumnSelection
- columns={serverTableColumns}
- onChange={(column) =>
serverTableColumnSelectionHandler.changeTableColumnSelection(column)}
- tableColumnsHidden={serverTableColumnSelectionHandler.hiddenColumns}
- />
- </ViewControlBar>
- {this.renderServersTable()}
-
- <div className="control-separator"/>
-
- <ViewControlBar label="MiddleManagers">
- <Button
- icon={IconNames.REFRESH}
- text="Refresh"
- onClick={() => this.middleManagerQueryManager.rerunLastQuery()}
- />
- <TableColumnSelection
- columns={middleManagerTableColumns}
- onChange={(column) =>
middleManagerTableColumnSelectionHandler.changeTableColumnSelection(column)}
-
tableColumnsHidden={middleManagerTableColumnSelectionHandler.hiddenColumns}
- />
- </ViewControlBar>
- {this.renderMiddleManagerTable()}
- </div>;
+ {
+ !noSqlMode &&
+ <Button
+ icon={IconNames.APPLICATION}
+ text="Go to SQL"
+ onClick={() => goToSql(this.serverQueryManager.getLastQuery())}
+ />
+ }
+ <Switch
+ checked={groupByTier}
+ label="Group by tier"
+ onChange={() => this.setState({ groupByTier: !groupByTier })}
+ />
+ <TableColumnSelection
+ columns={serverTableColumns}
+ onChange={(column) =>
serverTableColumnSelectionHandler.changeTableColumnSelection(column)}
+
tableColumnsHidden={serverTableColumnSelectionHandler.hiddenColumns}
+ />
+ </ViewControlBar>
+ {this.renderServersTable()}
+ </div>
+ <div className={'bottomPane'}>
Review comment:
`bottom-pane` plz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
