Fokko commented on a change in pull request #7810: Remove Apache Pig from the
tests
URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r289631462
##########
File path:
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/AvroFlattenerMaker.java
##########
@@ -128,8 +126,8 @@ public Object getRootField(final GenericRecord record,
final String key)
private Object transformValue(final Object field)
{
- if (fromPigAvroStorage && field instanceof GenericData.Array) {
- return Lists.transform((List) field, item ->
String.valueOf(((GenericRecord) item).get(0)));
+ if (field instanceof GenericData.Array) {
Review comment:
Thank you for reviewing @clintropolis, and I think you have a valid point
there. I'll comment the part, for now, let us see if the unit-tests. There is a
difference since the `List` below is a plain Java collection, and the
`GenericData.Array` is specific, so I expect a different outcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
