Fokko commented on a change in pull request #7810: Remove Apache Pig from the
tests
URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r292129697
##########
File path:
extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/avro/ParquetAvroHadoopInputRowParser.java
##########
@@ -92,6 +93,7 @@ private LogicalType determineTimestampSpecLogicalType(Schema
schema, String time
/**
* imitate avro extension {@link
org.apache.druid.data.input.avro.AvroParsers#parseGenericRecord}
*/
+ @Nonnull
Review comment:
Ah, I see now, thanks for pointing this out. I think the setting everything
to NonNull by default is the best practice, I'll pick this up in another PR if
that is fine by you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
