clintropolis commented on a change in pull request #7810: Remove Apache Pig
from the tests
URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r291374222
##########
File path:
extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/avro/ParquetAvroHadoopInputRowParser.java
##########
@@ -92,6 +93,7 @@ private LogicalType determineTimestampSpecLogicalType(Schema
schema, String time
/**
* imitate avro extension {@link
org.apache.druid.data.input.avro.AvroParsers#parseGenericRecord}
*/
+ @Nonnull
Review comment:
We aren't super consistent about this in the codebase but we strive to be
better, I think this isn't necessary because we all assume `@Nonnull` is the
default. You can enforce this with a package-info.java if you'd like, but it
should be fine to leave out as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
