clintropolis commented on a change in pull request #7810: Remove Apache Pig from the tests URL: https://github.com/apache/incubator-druid/pull/7810#discussion_r291373226
########## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectFlatteners.java ########## @@ -32,13 +32,8 @@ import java.util.function.Function; import java.util.stream.Collectors; -public class ObjectFlatteners +public abstract class ObjectFlatteners Review comment: This seems like an unneeded change, I guess it achieves the same thing, but I think it's a bit more confusing because I at least expect a class to be abstract because it's going to be implemented somewhere, where as previously it was obviously just trying to be a static class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
