clintropolis commented on a change in pull request #6794: Query vectorization. URL: https://github.com/apache/incubator-druid/pull/6794#discussion_r300890769
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/DoubleSumVectorAggregator.java ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation; + +import org.apache.druid.segment.vector.VectorValueSelector; + +import javax.annotation.Nullable; +import java.nio.ByteBuffer; + +public class DoubleSumVectorAggregator implements VectorAggregator +{ + private final VectorValueSelector selector; + + public DoubleSumVectorAggregator(final VectorValueSelector selector) + { + this.selector = selector; + } + + @Override + public void init(final ByteBuffer buf, final int position) + { + buf.putDouble(position, 0); + } + + @Override + public void aggregate(final ByteBuffer buf, final int position, final int startRow, final int endRow) + { + final double[] vector = selector.getDoubleVector(); + + double sum = 0; + for (int i = startRow; i < endRow; i++) { + sum += vector[i]; + } + + buf.putDouble(position, buf.getDouble(position) + sum); + } + + @Override + public void aggregate( + final ByteBuffer buf, + final int numRows, + final int[] positions, + @Nullable final int[] rows, + final int positionOffset + ) + { + final double[] vector = selector.getDoubleVector(); + + for (int i = 0; i < numRows; i++) { + final int position = positions[i] + positionOffset; + buf.putDouble(position, buf.getDouble(position) + vector[rows != null ? rows[i] : i]); Review comment: nit: maybe I'm being overly cautious and branch prediction will make this not matter, but why leave it to chance and maybe instead consider splitting this into `if (rows != null) { for ... } else { for ... }`. Same for float/long if you end up changing here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
