clintropolis commented on a change in pull request #6794: Query vectorization.
URL: https://github.com/apache/incubator-druid/pull/6794#discussion_r300895408
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferHashTable.java
##########
@@ -254,18 +253,21 @@ protected void initializeNewBucketKey(
* Find a bucket for a key, attempting to resize the table with
adjustTableWhenFull() if possible.
*
* @param keyBuffer buffer containing the key
- * @param keyHash hash of the key
+ * @param keyHash hash of the key
+ *
* @return bucket number of the found bucket or -1 if a bucket could not be
allocated after resizing.
*/
protected int findBucketWithAutoGrowth(
final ByteBuffer keyBuffer,
- final int keyHash
+ final int keyHash,
+ final Runnable preTableGrowthRunnable
Review comment:
Could you add javadoc about what is going on with here with `Runnable
preTableGrowthRunnable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
