himanshug commented on a change in pull request #8107: Add CliIndexer process
type and initial task runner implementation
URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307532931
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java
##########
@@ -463,6 +463,32 @@ public void nodeViewInitialized()
}
);
+ DruidNodeDiscovery druidNodeDiscoveryIndexer =
druidNodeDiscoveryProvider.getForNodeType(NodeType.INDEXER);
Review comment:
Instead of repeated code you can change line 441 to
```
DruidNodeDiscovery druidNodeDiscovery =
druidNodeDiscoveryProvider.getForService(WorkerNodeService.DISCOVERY_SERVICE_KEY);
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
