himanshug commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r307850373
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/SingleFileTaskReportFileWriter.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common; + +import org.apache.commons.io.FileUtils; +import org.apache.druid.java.util.common.logger.Logger; + +import java.io.File; +import java.util.Map; + +public class SingleFileTaskReportFileWriter extends TaskReportFileWriter +{ + private static final Logger log = new Logger(SingleFileTaskReportFileWriter.class); + + private final File reportsFile; + + public SingleFileTaskReportFileWriter(File reportsFile) + { + this.reportsFile = reportsFile; + } + + @Override + public void write(String taskId, Map<String, TaskReport> reports) Review comment: it is weird that instance of this class will retain and manage a map of taskId -> file (because it inherits TaskReportFileWriter) but those would be ignored all time. TaskReportWriter probably can be trimmed down a lot more, declared abstract/interface and have separate `MultiFileTaskReportFileWriter` wherever `TaskReportWriter` is currently used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
