clintropolis commented on a change in pull request #8209: add mechanism to
control filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310322021
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/BoundFilter.java
##########
@@ -45,13 +46,16 @@
import org.apache.druid.segment.column.BitmapIndex;
import org.apache.druid.segment.vector.VectorColumnSelectorFactory;
+import javax.annotation.Nullable;
import java.util.Comparator;
+import java.util.Set;
public class BoundFilter implements Filter
{
private final BoundDimFilter boundDimFilter;
private final Comparator<String> comparator;
private final ExtractionFn extractionFn;
+ private final FilterTuning manualFilterTuning;
Review comment:
I believe it is consistently called `filterTuning` on `DimFilter` and
`manualFilterTuning` on `Filter` implementations. This distinction is because
everything in `DimFilter` is manual since it was provided by the json query,
where as this is explictly the user set value on `Filter` implementations that
was supplied by the `DimFilter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
