clintropolis commented on a change in pull request #8209: add mechanism to 
control filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r310329610
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/filter/Filter.java
 ##########
 @@ -129,4 +131,52 @@ default boolean canVectorizeMatcher()
   {
     return false;
   }
+
+  /**
+   * Set of columns used by a filter
+   */
+  Set<String> getRequiredColumns();
+
+  /**
+   * "Manual" {@link FilterTuning} to allow explicit control of filter 
optimization behavior. This will likely be
+   * supplied by the {@link DimFilter} that is creating this {@link Filter}
+   */
+  @Nullable
+  FilterTuning getManualTuning();
+
+  /**
+   * This method allows a filter to automatically compute a {@link 
FilterTuning} based on information it can gather
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to